Re: [Rhythmbox-devel] [PATCH] add lirc support


Ah, I see.  It looks like a good idea for 0.9 as Colin previously
mentioned that the bonobo/remote functionality needed some work.  If a
plugin system were developed as recently discussed, the bonobo interface
would be great to use.  Hopefully support for the other operations that
are missing will be added.

As for 0.8, I feel the patch should be added as lirc is already
supported, and it provides a useful and completely optional feature with
no immediate alternative.  Either that or remove the current lirc
support from the 0.8 branch if its not going to be used.

Jon Oberheide

Jon Oberheide <jon focalhost com>
GnuPG Key: 1024D/0CF1526D
Fingerprint: C446 7193 D4B8 1E35 8984  7731 C661 64A5 0CF1 526D

On Tue, 2004-06-08 at 14:18, Christophe Fergeau wrote:
> Hi,
> See the attached file. It doesn't compile, nor is complete, but it is
> some proof of concept code. The main advantage of using the bonobo
> interface is that lirc support doesn't have to be enabled at compile
> time, and that rhythmbox doesn't depend on lirc. Instead you get a
> separate binary, which interested people can install.
> The main drawback with that approach is that the bonobo interface
> probably has a few bugs and lacks a few hooks to be able to do all that
> your patch does.
> Christophe
> > How would one interface lirc with bonobo?  The core lirc support is
> > already included in the current rhythmbox code.  It simply lacked the
> > correct environment needed to check for lirc and define
> > HAVE_REMOTE and the actual execution of thefeature commands received and parsed
> > by the lirc library.
> > 
> > > > BTW, is there a CVS repository for the .9 branch or is it only available
> > > > via arch?
> > > 
> > > Isn't CVS HEAD (module rhythmbox on or
> > > corresponding to the 0.9 branch ?
> > 
> > It appears as though is the 0.8 branch: 
> >  (from the
> > abundance of rhythmbox--main--0.8 imports and lack of 0.9's)
> > 
> > Regards,
> > Jon Oberheide
> > jon focalhost com

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]