Re: [Rhythmbox-devel] 0.9 branch, file monitoring implementation

[James Cotton <jcotton rice edu>]

Sorry in advance this is so long.  I had a few problems getting it to
compile which i managed to get around and make it work so I wanted to
let you know.

 gcc --version
gcc (GCC) 3.3.3 20040217 (Gentoo Linux 3.3.3, propolice-3.3-7)

and when it goes to compile rhythmdb.c (command below) it gives this
warning:

rhythmdb.c: In function `rhythmdb_execute_stat':
rhythmdb.c:1311: warning: `vfsresult' might be used uninitialized in
this function
make[2]: *** [rhythmdb.lo] Error 1
make[2]: Leaving directory
`/home/jcotton/source/rhythmbox--main--0.9--patch-11/rhythmdb'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/home/jcotton/source/rhythmbox--main--0.9--patch-11'make: *** [all]
Error 2

and dies.  looking at the code i can initialize the variable 
GnomeVFSResult vfsresult = GNOME_VFS_OK;
and it will compile fine.  Looking at the code it is clear that
vfsresult is assigned a value before being compared, but I guess this
version of gcc is not ok w/ that, and maybe fail on warnings is enabled?


Also, on line 2165 of shell/rb-shell.c there is a call to
rhythmdb_add_uri_async which grepping through all the code I can't find
another reference to.  There is a rhythmdb_add_uri though?  Changing it
allows it to compile.  

Now it compiles and runs.  However it doesn't install giving this error:

Making install in po
make[1]: Entering directory
`/home/jcotton/source/rhythmbox--main--0.9--patch-11/po'
if test -r ".././mkinstalldirs"; then \
  .././mkinstalldirs /usr/local/share; \
else \
  /bin/sh ../mkinstalldirs /usr/local/share; \
fi
./mkinstalldirs: ../mkinstalldirs: No such file or directory
make[1]: *** [install-data-yes] Error 127
make[1]: Leaving directory
`/home/jcotton/source/rhythmbox--main--0.9--patch-11/po'
make: *** [install-recursive] Error 1

There are a lot of warnings for automake for underquoted macros
definitons with automake-1.8
http://sources.redhat.com/automake/automake.html#Extending%20aclocal
which i think may be causing this.

Sorry this is so long, I hope this is helpful - i can file a bug report
or three if you would like.

james

P.S.  The library loads a lot faster now though, and with 0.7 i was
having to delete my rhythmbd.xml file regularly to stop it from locking
up.

the command for rhythmdb.c:

gcc -DHAVE_CONFIG_H -I. -I. -I..
-DGNOMELOCALEDIR=\"/usr/local//share/locale\"
-DG_LOG_DOMAIN=\"RhythmDB\" -I.. -I../lib -I../metadata -g -O2
-DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/X11R6/include
-I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0
-I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0
-I/usr/include/libart-2.0 -I/usr/include/gconf/2
-I/usr/include/libbonoboui-2.0 -I/usr/include/orbit-2.0
-I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0
-I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0
-I/usr/include/libxml2 -I/usr/include/libglade-2.0
-I/usr/include/gnome-vfs-module-2.0 -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -pthread -DORBIT2=1 -I/usr/include/gstreamer-0.8
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/libxml2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0
-Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes
-Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Werror
-std=c89 -I/usr/X11R6/include -g -O2 -Wno-strict-aliasing
-Wno-sign-compare -Wdeclaration-after-statement -MT rhythmdb.lo -MD -MP
-MF .deps/rhythmdb.Tpo -c rhythmdb.c  -fPIC -DPIC -o .libs/rhythmdb.o



On Sun, 2004-04-11 at 11:21 -0400, Colin Walters wrote:
> Hi,
> 
> I've opened up a rhythmbox--main--0.9 branch, and right now it has a
> major rewrite of RhythmDB.  I rewrote it along the lines discussed
> before in "rhythmdb post-mortem".  There's no read-write lock now. 
> Besides the main thread, there are really only two other threads.  One
> for doing queries, and another for handling filesystem tasks.
> 
> Also, I made a first cut at file monitoring.  It seems to work.
> 
> I suggest that if you're doing any development on Rhythmbox you start
> following 0.9 now.
>