Re: [Rhythmbox-devel] [PATCH] FLAC stream info

On Sun, 2003-09-21 at 19:08, Joshua Haberman wrote:

> I appreciate you soliciting my opinion on this.  

Well you fixed up the flac code, so :)

> Reading the code, I think that both blocks of code (the one existing and
> the one this patch creates) that "continue" out of the for loop should
> free(null_terminated_comment) or they will leak it.  This was an error
> with my original code.

Thanks, fixed.

Thanks for looking it over!

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]