Re: [Rhythmbox-devel] [PATCH] FLAC stream info

On Sun, 2003-09-21 at 15:43, Colin Walters wrote:
> Hey Joshua,
> Could you review the patch for the flac metadata here, and tell me
> whether it makes sense?
> Thanks!

I appreciate you soliciting my opinion on this.  The patch makes sense
to me.  The justification for this behavior is this document, that
states that the field name should be treated case-insensitively:

To me the comment /* normalize the fieldname to uppercase */ is slightly
more accurate than /* Make sure the fieldname is uppercase */.

Reading the code, I think that both blocks of code (the one existing and
the one this patch creates) that "continue" out of the for loop should
free(null_terminated_comment) or they will leak it.  This was an error
with my original code.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]