Re: [Rhythmbox-devel] monkey-media signal cleanups and errorhandling

[Jorn Baayen <jorn nl linux org>]

On Wed, 2003-01-29 at 20:04, Colin Walters wrote:
> On Wed, 2003-01-29 at 11:04, Jorn Baayen wrote:
> > Hi,
> > 
> > Looks good, some comments though:
> > 
> > What's with the block_errors stuff? 
> 
> Well, if closing the stream throws an error, I didn't want to get in to
> a recursive error signalling loop.  

It would be cleaner to just disconnect the signal, then.

> 
> > The _close call in _finalize should
> > just be a gst_element_set_state on the main pipeline to the NULL state,
> > btw.. 
> 
> Ok, done.
> 
> > and the error signal should use GError, 
> 
> Done.
> 
> > and error_cb needs some spacing ;)
> 
> What's wrong with the spacing?

Maybe it's like, cramped, at the moment? ;)

Cheers

> 
> BTW, here's a screenshot of the branch using the new error handling
> stuff:
> 
> http://web.verbum.org/~walters/files/shots/38.html
> 
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel@gnome.org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel