Re: [Rhythmbox-devel] monkey-media signal cleanups and errorhandling


Looks good, some comments though:

What's with the block_errors stuff? The _close call in _finalize should
just be a gst_element_set_state on the main pipeline to the NULL state,
btw.. and the error signal should use GError, and error_cb needs some
spacing ;)


On Wed, 2003-01-29 at 08:24, Colin Walters wrote:
> Hello,
> The attached patch implements error handling separately from the
> previous patch, as requested on IRC.  It also ensures that every async
> callback queued in the glib main loop holds an object reference.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]