Re: [Rhythmbox-devel] monkey-media signal cleanups and errorhandling

On Wed, 2003-01-29 at 11:04, Jorn Baayen wrote:
> Hi,
> Looks good, some comments though:
> What's with the block_errors stuff? 

Well, if closing the stream throws an error, I didn't want to get in to
a recursive error signalling loop.  

> The _close call in _finalize should
> just be a gst_element_set_state on the main pipeline to the NULL state,
> btw.. 

Ok, done.

> and the error signal should use GError, 


> and error_cb needs some spacing ;)

What's wrong with the spacing?

BTW, here's a screenshot of the branch using the new error handling

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]