[Rhythmbox-devel] Problem skipping in Playlist

[Mason Kidd <mrkidd mrkidd com>]

I'm having a problem going back to the previous song in a playlist. 
What I did:
Create new playlist with selected songs, then added some more songs to
it.  
Started playing the first song.
Pressed the '>|' button to skip to the fourth song.
Clicked on 'Library' in the locations bar
Clicked on the '|<' button to go back a song.  
This just went back to the beginning of the current song.

Tested this some more, and after playing a song in the playlist, as soon
as you click on Library, the back button breaks.  The forward button
works fine.  Attached is a patch to fix this.  (Unless this is by design
of course, but it seems non-intuitive to me if it is)
-- 
Mason Kidd
<mason.kidd@mrkidd.com>

--- shell/rb-shell-player.c.orig	2003-08-09 15:17:27.000000000 -0700
+++ shell/rb-shell-player.c	2003-08-09 15:17:57.000000000 -0700
@@ -848,7 +848,7 @@
 rb_shell_player_do_previous (RBShellPlayer *player)
 {
 	if (monkey_media_player_get_time (player->priv->mmplayer) < 3 &&
-	    rb_shell_player_have_previous (player,
player->priv->selected_source) == TRUE) {
+	    rb_shell_player_have_previous (player, player->priv->source) ==
TRUE) {
 		rb_debug ("doing previous");
 		/* we're in the first 2 seconds of the song, go to previous */
 		rb_shell_player_previous (player);

--- shell/rb-shell-player.c.orig	2003-08-09 15:17:27.000000000 -0700
+++ shell/rb-shell-player.c	2003-08-09 15:17:57.000000000 -0700
@@ -848,7 +848,7 @@
 rb_shell_player_do_previous (RBShellPlayer *player)
 {
 	if (monkey_media_player_get_time (player->priv->mmplayer) < 3 &&
-	    rb_shell_player_have_previous (player, player->priv->selected_source) == TRUE) {
+	    rb_shell_player_have_previous (player, player->priv->source) == TRUE) {
 		rb_debug ("doing previous");
 		/* we're in the first 2 seconds of the song, go to previous */
 		rb_shell_player_previous (player);
--- shell/rb-shell-player.c.orig	2003-08-09 15:17:27.000000000 -0700
+++ shell/rb-shell-player.c	2003-08-09 15:17:57.000000000 -0700
@@ -848,7 +848,7 @@
 rb_shell_player_do_previous (RBShellPlayer *player)
 {
 	if (monkey_media_player_get_time (player->priv->mmplayer) < 3 &&
-	    rb_shell_player_have_previous (player, player->priv->selected_source) == TRUE) {
+	    rb_shell_player_have_previous (player, player->priv->source) == TRUE) {
 		rb_debug ("doing previous");
 		/* we're in the first 2 seconds of the song, go to previous */
 		rb_shell_player_previous (player);
--- shell/rb-shell-player.c.orig	2003-08-09 15:17:27.000000000 -0700
+++ shell/rb-shell-player.c	2003-08-09 15:17:57.000000000 -0700
@@ -848,7 +848,7 @@
 rb_shell_player_do_previous (RBShellPlayer *player)
 {
 	if (monkey_media_player_get_time (player->priv->mmplayer) < 3 &&
-	    rb_shell_player_have_previous (player, player->priv->selected_source) == TRUE) {
+	    rb_shell_player_have_previous (player, player->priv->source) == TRUE) {
 		rb_debug ("doing previous");
 		/* we're in the first 2 seconds of the song, go to previous */
 		rb_shell_player_previous (player);
--- shell/rb-shell-player.c.orig	2003-08-09 15:17:27.000000000 -0700
+++ shell/rb-shell-player.c	2003-08-09 15:17:57.000000000 -0700
@@ -848,7 +848,7 @@
 rb_shell_player_do_previous (RBShellPlayer *player)
 {
 	if (monkey_media_player_get_time (player->priv->mmplayer) < 3 &&
-	    rb_shell_player_have_previous (player, player->priv->selected_source) == TRUE) {
+	    rb_shell_player_have_previous (player, player->priv->source) == TRUE) {
 		rb_debug ("doing previous");
 		/* we're in the first 2 seconds of the song, go to previous */
 		rb_shell_player_previous (player);