Re: NetworkManager-vpnc 0.9.3.995

[Dan Williams <dcbw redhat com>]

On Fri, 2012-03-02 at 20:18 +0100, Olav Vitters wrote:
> On Fri, Mar 02, 2012 at 06:19:28PM +0000, Dan Williams wrote:
> > http://download.gnome.org/sources/NetworkManager-vpnc/0.9/NetworkManager-vpnc-0.9.3.995.tar.xz (326K)
> >   sha256sum: 1e0542aebbe40ced9d68271e990cf1d11b6fd6abeef528c727be58eb0c9e868c
> 
> Doesn't build because of -Werror (GtkGrid):
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20120302184611.pterjan.valstar.3609/log/networkmanager-vpnc-0.9.3.995-1.mga2/build.0.20120302184613.log
> 
> On Fri, Mar 02, 2012 at 06:19:23PM +0000, Dan Williams wrote:
> > http://download.gnome.org/sources/NetworkManager-pptp/0.9/NetworkManager-pptp-0.9.3.995.tar.xz (317K)
> >   sha256sum: 422b9930b2d27f5009561f69165156ced5d2a800d1b3954cc8c8d5b40d2d9c15
> 
> Doesn't build because of -Werror (GtkGrid):
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20120302184323.pterjan.valstar.2446/log/networkmanager-pptp-0.9.3.995-1.mga2/build.0.20120302184427.log
> 
> 
> Please do not use -Werror in tarballs. Note that NetworkManager itself
> also fails, but at least not due to -Werror:

-Werror isn't the problem, that catches bugs.  What's the problem is
that these by default enable deprecation warnings, which trigger the
Werror.  We've fixed that for the applet at least, but not the VPN
plugins.  So we'll turn deprecation warnings off for the plugins too,
since code that supports both GtkGrid and the old stuff is a pain in the
ass, and hopefully we can just ride the old code until it gets fully
removed from Gtk.

Dan

> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20120302191059.ovitters.valstar.22359/log/networkmanager-0.9.3.995-1.mga2/build.0.20120302191100.log
> 
> | nm-device-vlan.c: In function 'carrier_watch_init':
> | nm-device-vlan.c:541:32: error: 'IFF_LOWER_UP' undeclared (first use in
> | this function)
> | nm-device-vlan.c:541:32: note: each undeclared identifier is reported
> | only once for each function it appears in
> 
> I'm still checking that error.
>