Re: Another Orca code-freeze-break request

[Frederic Peters <fpeters gnome org>]

Hi Joanmarie,

>              if keycode != 0:
> -                success, entries = keymap.get_entries_for_keycode(keycode)
> +                entries_for_keycode = keymap.get_entries_for_keycode(keycode)
> +                success = entries_for_keycode[0]
> +                entries = entries_for_keycode[1]

>              keymap = Gdk.Keymap.get_default()
> -            success, entries = keymap.get_entries_for_keycode(event.hw_code)
> +            entries_for_keycode = keymap.get_entries_for_keycode(event.hw_code)
> +            success = entries_for_keycode[0]
> +            entries = entries_for_keycode[1]
>              event.event_string = Gdk.keyval_name(entries[0].keycode)

I don't see how those two chunks change anything. Given the traceback
in the bug report, there should be some "if entries_for_keycode is not
None" before referencing its parts.

Am I missing something?


        Fred