Re: gnome-settings-daemon hard code freeze break

[Matthias Clasen <matthias clasen gmail com>]

On Mon, Sep 26, 2011 at 10:13 AM, Frederic Peters <fpeters gnome org> wrote:
> Richard Hughes wrote:
>
>> Three potential fixes for gnome-3-2 consideration please:
>>
>> Trivial fix, low risk: removes a warning in xsession:
>> http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=67785fa2b1043bd5397669f92abbd210dbf23f24
>>
>> Trivial fix, low risk: remove two missing refcount leaks:
>> http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=09c582d9e31580fbfced001811006617dfad5ef9
>
> Both look ok but could as well go in 3.2.1, avoiding a warning on
> xsession-errors and a few small leaks is nice to have, but not the
> kind of code break suitable the day of the release. I'll let two other
> members give the approval if they feel like it.
>
>
>> Not trivial, complicated, medium risk: actually make suspend on idle
>> work correctly:
>> http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=bdde7b7db788926adaa9fd1e80f2af606deb1d24
>> -- see https://bugzilla.gnome.org/show_bug.cgi?id=659066 for details.
>> It's been tested by 3 people, and it probably quite important for
>> 3.2.0
>
> On the other hand this looks like a real problem, too bad the trivial
> patches were not for this one…  But it has been tested, I'd give +1 on
> this.

I agree. I'm interested in the suspend-on-idle fix for 3.2.0, the
others can wait for 3.2.1