Re: gnome-control-center freeze request

On mar, 2011-09-20 at 09:36 -0400, Matthias Clasen wrote:
> On Tue, Sep 20, 2011 at 9:01 AM, Rodrigo Moya <rodrigo gnome org> wrote:
> > Hi
> >
> > I completely forgot about the freeze request, and so pushed this change
> > to gnome-control-center:
> >
> >
> >
> > so, asking now for freeze request. If not approved, I'll revert it.
> >
> > The bug the commit message points to explains the problem
> While I agree that show is more correct than show_all there, I think
> there's a considerable risk of fallout from this (and I think you are
> already seeing some ?). To be clear: if we take this patch, stuff
> might just disappear from any panel. If we don't take the patch, we
> know that some extra things will show up in certain circumstances
> (when running gnome-control-center a second time).
yes, I've found only one little thing that my patch broke, which I just
sent a patch for approval. Apart from that, everything seems to be ok.
When the shell starts for the 1st time, only the main view is available,
and no panels are affected by whether we use _show or _show_all. Whereas
on the 2nd run of the shell, the situation is really bad (try it with
3.1.92, you will see in all panels lots of widgets showing up).

So, nothing disappears from any panel at all with my 2 patches applied,
since, as I said, on the 1st run no panel is active, and on the 2nd,
_show would just show what is still being shown, not hide anything.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]