Re: possible freeze break: pyatspi2 should raise LookupError forIPC errors

[Vincent Untz <vuntz gnome org>]

Le dimanche 27 mars 2011, à 21:47 -0500, Mike Gorse a écrit :
> @@ -56,7 +57,10 @@ class Document:
>                  @return an AttributeSet containing the attributes of the document,
>                  as name-value pairs.
>                  """
> -                ret = Atspi.Document.get_attributes(self.obj)
> +                try:
> +                        ret = exwrap(Atspi.Document.get_attributes, self.obj)
> +                except: 
> +                        raise

I don't think you need to do the try/except here (and in a few other
places), since you simply raise the same exception.

Aprt from that, I'm happy with the patch. Approval 1 of 2.

Vincent

-- 
Les gens heureux ne sont pas pressés.