Re: gnome-settings-daemon patches

[Bastien Nocera <hadess hadess net>]

On Fri, 2011-03-25 at 11:37 +0100, Frederic Crozat wrote:
> On Fri, Mar 25, 2011 at 4:34 AM, Bastien Nocera <hadess hadess net> wrote:
> > On Thu, 2011-03-24 at 23:02 -0400, Matthias Clasen wrote:
> >> On Thu, Mar 24, 2011 at 10:38 PM, Bastien Nocera <hadess hadess net> wrote:
> >>
> >> > Attached
> >> >
> >>
> >> All three look good to me. This should make our a11y support a little
> >> less dire for 3.0.
> >>
> >> +1/2
> >
> > https://bugzilla.gnome.org/show_bug.cgi?id=645708
> > which is "no way to start orca in UI" reads:
> >
> >> I feel uncomfortable with this patch to gnome-control-center as it
> >> breaks:
> >> - Documentation
> >> - String freeze
> >> - Code freeze
> >> and, in my testing with a non-functional Orca within my jhbuild
> >> session, gnome-session went beserk trying to start orca, spawning Orca
> >> and festival in terminals over and over. gnome-session also saw fit to
> >> keep festival in my session, across a login/logout, blocking the shell
> >> from starting (pulseaudio/festival race?).
> >>
> >> I'll commit it first thing in 3.2, and watch orca make my session fall
> >> over.
> >
> > Unless somebody can give this a good shake to check whether it's my
> > machine acting up, I won't be committing the UI patch.
> 
> There was a bug in orca which was still checking gconf key instead of
> gsettings, attached patch fixes it. With it and patches in
> gnome-control-center + gnome-settings-daemon + at-spi2-core, orca
> starts correctly when enabled from g-c-c. The only missing part is
> a11y support for gnome-shell which needs the full session to be
> restarted to be effective in gnome-shell.
> 
> Requesting freeze break for orca patch (I'm cc orca-devel-list to keep
> orca people in the loop)
> 
> I'd say you should commit the g-c-c bits for 3.0

I've committed the UI patch to 3.0, Frederic will send an updated
screenshot to the documentation people.

Cheers