gnome-desktop commit causes XServer breakage

[Cosimo Cecchi <cosimoc gnome org>]

Hi everyone,

Last week I pushed this patch by Ray [1] on gnome-desktop master. The
patch is intended to make background fade work properly at login, as
it's explained in the linked bug report [2].

Unfortunately, the patch, although correct, triggers a crash in the X
server every time gnome-desktop tries to set a background; I actually
pushed that to master by mistake, as I had it in my tree for testing,
and Ray made me notice it was upstream only today (sorry about that).

So, the options are now:
- revert the patch from gnome-desktop master and make another release,
which I would happily take care of
- test the Xorg patches at [3], which are supposed to fix similar X
crashes, and if they do fix this too, make sure every distributor ships
them together with 3.0.

I personally slightly lean towards the safest revert approach at this
point.

[1]
http://git.gnome.org/browse/gnome-desktop/commit/?id=e36d931ca2aad168427e22d23f9013316854370e
[2] https://bugzilla.gnome.org/show_bug.cgi?id=641526
[3] http://lists.x.org/archives/xorg-devel/2011-February/018936.html

Thanks,

Cosimo