Re: Empathy Hard code freeze exception request: Hard to accept incoming calls and file transfer (#645932)

[Guillaume Desmottes <gdesmott gnome org>]

Le vendredi 01 avril 2011 à 17:17 -0400, Matthias Clasen a écrit :
> On Fri, Apr 1, 2011 at 3:52 PM, Owen Taylor <otaylor redhat com> wrote:
> > On Fri, 2011-04-01 at 19:08 +0200, Guillaume Desmottes wrote:
> >> Le 31/03/2011 15:42, Frederic Peters a écrit :
> >> > Guillaume Desmottes wrote:
> >> >
> >> >> https://bugzilla.gnome.org/show_bug.cgi?id=645932#c18
> >> >>
> >> >> Atm it's very hard for users to notice incoming calls, file transfer,
> >> >> muc invitations, etc because the Shell blacklist all the notifications
> >> >> from Empathy. It should only ignore the chat ones (as they are replaced
> >> >> by the message tray) so I cooked 2 branches doing that:
> >> >>
> >> >> http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/shell-notif-645932
> >> >> http://git.collabora.co.uk/?p=user/cassidy/gnome-shell;a=shortlog;h=refs/heads/empathy-notif-645932
> >> >>
> >> >>
> >> >> I still have to ask Owen before considering merging the shell branch,
> >> >> but we could already merge the Empathy one.
> >> >> Even if the Shell patch is not merged for 3.0, merging the Empathy
> >> >> patches shouldn't hurt and will ensure that Empathy 3.0 is ready.
> >> >>
> >> >> Jonny already reviewed the patches.
> >> > They look fine; let's wait a bit for an answer from Owen on the shell
> >> > part.
> >>
> >> Dan reviewed and tested the Shell patch as well, so all we need now is
> >> Owen and the RT approval.
> >> https://bugzilla.gnome.org/show_bug.cgi?id=645932
> >
> > I'm good with the gnome-shell patch. (It has the side-effect of causing
> > duplicate notifications with Empathy without these patches, but I'm much
> > more concerned about GNOME 3 working well as a unit rather than as
> > mismatched component versions.)
> 
> Ok, then I'll give the second release team approval.

Great; I merged both branches.

Thanks everyone!


	G.

-- 
Guillaume Desmottes <gdesmott gnome org>
Jabber <cassidy jabber belnet be>
GPG 1024D/711E31B1 | 1B5A 1BA8 11AA F0F1 2169  E28A AC55 8671 711E 31B1