freeze break request for the file-roller module



Hi,

File Roller allows to install the missing packages if a command is not available, for example if the user opens a rar archives but the unrar utility is not available the user will be asked if he wants to install the rar package, this is done by calling the PackageKit service.

The current code has a bug that prevents this feature to work correctly, because the call to the PackageKit service has the wrong parameters format and uses a timeout that should be disabled instead.

The attached patch has already been tested by me (the module's maintainer) and it fixes the problem.

- Paolo
>From 88d95a6a371b85ee63ff57c3102555cdffa3b286 Mon Sep 17 00:00:00 2001
From: Paolo Bacchilega <paobac src gnome org>
Date: Tue, 14 Sep 2010 13:42:30 +0200
Subject: [PATCH] fixed call to the package installer

Fixed the parameters format and don't use a timeout.

[bug #629604]

---
 src/dlg-package-installer.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/dlg-package-installer.c b/src/dlg-package-installer.c
index d50af2d..d1f9e94 100644
--- a/src/dlg-package-installer.c
+++ b/src/dlg-package-installer.c
@@ -183,12 +183,12 @@ install_packages (InstallerData *idata)
 
 			g_dbus_proxy_call (proxy,
 					   "InstallPackageNames",
-					   g_variant_new ("(u^asms)",
+					   g_variant_new ("(u^ass)",
 							  xid,
 							  names,
 							  "hide-confirm-search,hide-finished,hide-warning"),
 					   G_DBUS_CALL_FLAGS_NONE,
-					   -1,
+					   G_MAXINT,
 					   NULL,
 					   packagekit_install_package_names_ready_cb,
 					   idata);
-- 
1.7.1



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]