Cheese code freeze break request

[Filippo Argiolas <fargiolas gnome org>]

Hi,
I have a couple of bug fixes I'd like to commit before 2.30.

Cheese crashes when taking a photo or recording a video in fullscreen
(High / critical)
  Bug: https://bugzilla.gnome.org/show_bug.cgi?id=592100
  Patch: https://bugzilla.gnome.org/attachment.cgi?id=156945&action=diff

This is a particular nasty crasher that happens every time you use the
fullscreen mode if window and button sounds are enabled.
We finally found the culprit and I'd really like to include the fix in
the upcoming major release.
The bug has pretty good explanation and references about the reason it
happened and why it is fixed this way
Summarizing it: we called rsvg_term() that triggers an
xmlCleanupParser call and as per libxml docs that should never be
called except before exit as it cleans up all the global memory owned
by libxml causing bad crashes with multithread applications.
See also [1] and [2] for more informations.


Text always stays as "Start recording" (Normal / normal)
  Bug: https://bugzilla.gnome.org/show_bug.cgi?id=613421
  Patch: https://bugzilla.gnome.org/attachment.cgi?id=156664&action=diff

This is pretty trivial, just a typo. The text in the main button is
supposed to change to "Stop recording" after recording is started but
right now it remains unchanged.
Note that it doesn't involve any string change as the labels are
defined in global macros and it's just a matter of using the right
one.


use an existing icon (Normal / normal)
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=613067
Patch: https://bugzilla.gnome.org/attachment.cgi?id=156291&action=diff

Another trivial one. The "error" icon displayed when there is no
camera apparently doesn't exist anymore in gnome-icon-theme. Use
"dialog-error" icon instead. I approved this patch right before the
freeze but didn't have the time to actually commit it.


Thanks,

Filippo



1. http://0pointer.de/blog/projects/beware-of-rsvg-term.html
2. http://0pointer.de/blog/projects/beware-of-xmlCleanupParser