Freeze exception request for gnome-system-tools and liboobs



Hi!

Thanks to awesome but late testers, I've been able to identify and fix a
few critical bugs recently. All of these can be fixed easily, so I'd
like to push them this week. I know this makes up many patches, but this
is because almost nobody is testing the GNOME System Tools until Ubuntu
users start running the beta... As for the 4th patch, I'm not sure we
really need to commit it now - but others are definitely major.


1. Fix "Reload config?" dialog shown after creating a group
This one is really silly: every time a group is
created/modified/deleted, a dialog pops up saying that system
configuration was changed. The fix is really trivial, one line to add,
and this is what we already do for users.


2. Fix hiding "encrypt home folder" option when not supported
A missing gtk_widget_hide() meant that we show this option even when the
distro doesn't support it, or the tools are not installed.


3. Force updating groups when showing groups dialog
When a user has just been created or deleted, groups can have changed
because of automated main group creation. ATM, we won't reflect those
changes, which is confusing to advanced users. I'm not very happy with
it, because that hack slows down loading the dialog, but... We need a
proper fix in the long term.


4. Don't hang when new and old password only differ in case
This one is less important. When (if?) people change their password to
something that only differs in case from old password, then users-admin
hangs. The same bug affects gnome-about-me, it's because we don't detect
the output from 'passwd' in this case. The use case is not very
frequent, but since the patch is here...


And for liboobs:

1. Fix wrong list passed to oobs_list_iter_next()
This fixes a typo which can lead us to commit to /etc/group logins of
users that were just removed. Not really a good idea security-wise.


Regards, I hope I'm not abusing your time !






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]