Re: (Glade) Some last minute show stopper bugs

[Vincent Untz <vuntz gnome org>]

Le dimanche 15 mars 2009, à 19:25 -0400, Tristan Van Berkom a écrit :
> Can I please please commit fixes for these bugs:
> 
>  - http://bugzilla.gnome.org/show_bug.cgi?id=574706
>    (A really dumb crasher bug)

Approval 1 of 2. But note that I would add:

else {
	glade_util_ui_message (GTK_WIDGET (window), GLADE_UI_ERROR, NULL,
	       _("Failed to save %s: %s"),
	       display_path, "");
}

(note the hack to not introduce any new string)

>  - http://bugzilla.gnome.org/show_bug.cgi?id=575206
>    (A crasher on win32 when formatting NULL into %s) -
> http://bugzilla.gnome.org/show_bug.cgi?id=575206

Still no patch. Sure, it's trivial, but let's make sure it's done right
:-)

>  - http://bugzilla.gnome.org/show_bug.cgi?id=576809
>    (Widget names unusable, I have a fix ready for this and will
>    attach the very small patch to the bug presently...)

This is http://bugzilla.gnome.org/show_bug.cgi?id=567809

Seems to make sense to me. If you guarantee me you have test the patch
thoroughly, then approval 1 of 2 (because it's really a usability
nightmare if you can't cut&paste widgets anymore).

(oh, and Matthias gave the first approval, so my approval is the second
for this patch)

Vincent

-- 
Les gens heureux ne sont pas pressés.