Re: hard code freeze break request

[Alexander Larsson <alexl redhat com>]

On Tue, 2009-03-10 at 11:37 +0100, Frederic Crozat wrote:
> Le mardi 10 mars 2009 à 11:12 +0100, Alexander Larsson a écrit :
> > I've just fixed a silly bug in the sftp gvfs backend. When it asks for
> > the passphrase for a ssh key it also asks for the username. The fix is
> > easy:
> > 
> > --- daemon/gvfsbackendsftp.c    (revision 2306)
> > +++ daemon/gvfsbackendsftp.c    (working copy)
> > @@ -851,13 +851,14 @@ handle_login (GVfsBackend *backend,
> >                
> >                if (g_vfs_keyring_is_available ())
> >                  flags |= G_ASK_PASSWORD_SAVING_SUPPORTED;
> > -             if (!op_backend->user_specified)
> > +             if (strcmp (authtype, "password") == 0 &&
> > +                 !op_backend->user_specified)
> >                 flags |= G_ASK_PASSWORD_NEED_USERNAME;
> > 
> > 
> > Permission to commit this?
> 
> Looks fine
> 
> Approval 1 of 2.
> 
> (it would have been nice if there was also a bug number, if available ;)

There is no bugzilla, this was reported on irc :)