Evolution Freeze break



Hello guys,

I have made a patch for
http://bugzilla.gnome.org/show_bug.cgi?id=552729 

It is a regression due to disk summary branch and a pretty simple code,
that matches search fields to db table fields where I had missed two
fields. The same function is correctly implemented inside the test suite
[1] for search expression conversion, but missed in the actual code 
It is critical, as search and vfolders with such queries won't work, for
users migrating from 2.22. I have tested it and it works now. 

-Srini.

[1] - Line 621: camel_db_get_column_name
diff --git a/camel/camel-db.c b/camel/camel-db.c
index b76775c..a14624a 100644
--- a/camel/camel-db.c
+++ b/camel/camel-db.c
@@ -1088,6 +1088,8 @@ camel_db_get_column_name (const char *raw_name)
 		return g_strdup ("deleted");
 	else if (!g_ascii_strcasecmp (raw_name, "junk"))
 		return g_strdup ("junk");
+	else if (!g_ascii_strcasecmp (raw_name, "Answered"))
+		return g_strdup ("replied");	
 	else if (!g_ascii_strcasecmp (raw_name, "Seen"))
 		return g_strdup ("read");
 	else if (!g_ascii_strcasecmp (raw_name, "user-tag"))
@@ -1096,14 +1098,10 @@ camel_db_get_column_name (const char *raw_name)
 		return g_strdup ("labels");	
 	else if (!g_ascii_strcasecmp (raw_name, "Attachments"))
 		return g_strdup ("attachment");
-	else {
-		/* Let it crash for all unknown columns for now. 
-		We need to load the messages into memory and search etc. 
-		We should extend this for camel-folder-search system flags search as well 
-		otherwise, search-for-signed-messages will not work etc.*/
-
+	else if (!g_ascii_strcasecmp (raw_name, "x-camel-mlist"))
+		return g_strdup ("mlist");	
+	else
 		return g_strdup (raw_name);
-	}
 
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]