Re: Hard code freeze break request for control-center

["Matthias Clasen" <matthias clasen gmail com>]

On Wed, Sep 17, 2008 at 5:30 PM, Jens Granseuer <jensgr gmx net> wrote:
> Hey,
>
> the attached patch fixes bug
>
> 552671 - Overwriting a theme doesn't work
>
> The bug rept in as a result of the gio transition, and as
> such, this is a regression from the 2.22 release.
>
> The patch is pretty straigth-forward and has low to no
> impact on everything else.
>
> Jens
>
> Index: capplets/appearance/theme-save.c
> ===================================================================
> --- capplets/appearance/theme-save.c    (revision 8967)
> +++ capplets/appearance/theme-save.c    (working copy)
> @@ -204,7 +204,7 @@ write_theme_to_disk (GnomeThemeMetaInfo
>      theme_info->metacity_theme_name,
>                         theme_info->icon_theme_name);
> -  output = G_OUTPUT_STREAM (g_file_create (tmp_file, G_FILE_CREATE_NONE,
> NULL, NULL));
> +  output = G_OUTPUT_STREAM (g_file_replace (tmp_file, NULL, FALSE,
> G_FILE_CREATE_NONE, NULL, NULL));
>   g_output_stream_write (output, str, strlen (str), NULL, NULL);
>   g_free (str);
> @@ -255,7 +255,7 @@ write_theme_to_disk (GnomeThemeMetaInfo
> g_object_unref (client);
>   }
> -  g_file_move (tmp_file, target_file, G_FILE_COPY_NONE, NULL, NULL, NULL,
> NULL);
> +  g_file_move (tmp_file, target_file, G_FILE_COPY_OVERWRITE, NULL, NULL,
> NULL, NULL);
>   g_output_stream_close (output, NULL, NULL);
>   g_object_unref (tmp_file);

Looks fine to me.
Approval 1 of 2