Re: GVFS SMB Kerberos fix - Request for code freeze break

["Matthias Clasen" <matthias clasen gmail com>]

On Tue, Sep 16, 2008 at 11:44 AM, Tomas Bzatek <tbzatek redhat com> wrote:
> Hello release-team,
>
> kindly asking for permission to break the Hard Code Freeze and commit
> the attached patch to gvfs/branches/gnome-2-24.
>
> Bug 524498 – display authentification dialog rather than just using
> kerberos credentials
> http://bugzilla.gnome.org/show_bug.cgi?id=524498
>
> This patch fixes Kerberos authentication in the SMB backend, where user
> connecting to a Samba share and holding valid Kerberos ticket was
> repeatedly asked for credentials and connection succeeded only when the
> login dialog was cancelled.
>
> Due to general bad shape of the GVFS SMB backend I recommend to include
> this fix in the upcoming 2.24 release.
>
> The maintainer of the GVFS library (Christian Kellner <gicmo gnome org>)
> has reviewed the patch and agrees with the commit.
>
> Patch has been tested on a pool of Samba servers with various
> configuration, including Windows 2003 Server configured as Active
> Directory Domain Controller and Kerberos server.
>
> This is a functional fix, affecting all Gnome modules using GIO. No
> strings have been changed.

+1 from me, considering that the smb backend is pretty much unusable
as it is right now, and the patch has some testing.

Are there more smb fixes in the queue, or does this bring us the gvfs
smb backend to a fully working state ?


Matthias