Re: Hard code freeze break request [gnome-games:glchess]

[Vincent Untz <vuntz gnome org>]

Le lundi 10 mars 2008, à 10:03 +0100, Frederic Crozat a écrit :
> 
> Le lundi 10 mars 2008 à 15:03 +1100, Robert Ancell a écrit :
> > Hi,
> > 
> > I would like to request a code-freeze break for the following two
> > bugs. Neither bug has a UI or translation impact. Patches for the bugs
> > are attached to their bug reports.
> > 
> > Bug 1: Quitting AI processes incorrectly reported as AI death
> > http://bugzilla.gnome.org/show_bug.cgi?id=517347
> > 
> > Cause: Recent changes to detect subprocess death have meant a normally
> > terminating process (e.g. a chess engine at the end of the game) is
> > now detected and interpreted as an unexpected death.
> > Impact: Resigning in a human-AI game will cause the human player to
> > win and report the AI has died.
> > Solution: Don't detect chess engine death once manually requested it to quit.
> 
> Approval 1 of 2

Since it's late, I'll give a second approval if two people tell me they
tested the patch and that it works fine, without any other regression.

> > Bug 2: Some PyGTK installations require pygtk.require() to be called
> > http://bugzilla.gnome.org/show_bug.cgi?id=521154
> > 
> > Cause: The pygtk.require() call was accidentally removed.
> > Impact: Users of these systems will be unable to start Chess.
> > Solution: Re-add the missing call.
> 
> Approval 1 of 2

Are we talking about the patch in bug 521154 or in bug 483556? Anyway,
both are fine for me. Approval 2 of 2.

Vincent

-- 
Les gens heureux ne sont pas pressés.