conflit in gnome-mag CLI



PS.: Please, CC me in the reply, since I'm not subscribed to this list.

Hi,

I inserted a conflit in the gnome-mag CLI with the patch in:
http://bugzilla.gnome.org/show_bug.cgi?id=397819

I don't realized when patching it that the -v option was already being
used to mean --vertical and modified it to mean --version. Since the -v
option to mean --vertical is a well know option I ask for permission to
change it before 2.18 since the --version option doesn't existed before
and the patch is really very simple as can be saw in the attached patch.

Best regards,
Carlos.
Index: magnifier/magnifier-main.c
===================================================================
--- magnifier/magnifier-main.c	(revision 466)
+++ magnifier/magnifier-main.c	(working copy)
@@ -140,7 +140,7 @@
 #ifdef HAVE_COMPOSITE
 	{"ignore-composite", 0, 0, G_OPTION_ARG_NONE, &global_options.ignore_composite, "ignore the X server COMPOSITE extension, if present", NULL},
 #endif /* HAVE_COMPOSITE */
-	{"version", 'v', 0, G_OPTION_ARG_NONE, &global_options.print_version, "print version", NULL},
+	{"version", 0, 0, G_OPTION_ARG_NONE, &global_options.print_version, "print version", NULL},
 	{NULL}
 };
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]