Re: [evolution-patches] Re: patch for bug 312857

[Harish Krishnaswamy <kharish novell com>]

Oops !!! This is  big-time screw up. The patch had been reviewed offline
and a wrong earlier version posted to the list. Thanks for pointing it
out. Apologies to the release team..

Vivek/Partha : Can you pl. make sure the right patch is posted to the
list.

Harish

On Mon, 2005-09-05 at 10:19 +0800, Not Zed wrote:
> You have totally got to be kidding me.  This code can't possible work
> reliably, it has a blatantly obvious race just setting up the mutex.  A
> static mutex MUST be pre-initialised or initialised using some other
> atomic means.
> 
> +       if (!mutex)
> +               mutex = g_mutex_new ();
>  
> +       if (!g_mutex_try_lock (mutex))
> +               return;
>