Hard code freeze break request for gnome-applets.



I just got a report from 'tseng' on IRC that he is having difficulty
with the HAL backend of battstat applet.

http://bugzilla.gnome.org/show_bug.cgi?id=315259

As always seems to be the case his troubles were caused by a bad ACPI
implementation.

Essentially, when the battery is fully charged, the ACPI reports a
'remaining capacity' much higher than the last full capacity.  This
results in battstat displaying 204% when using the HAL backend.

This is a regression as compared to the oldschool ACPI implementation in
battstat since the old implementation clamped the percentage between 0
and 100.  I didn't perform this value clamping in the HAL backend since
I (wrongly) assumed that ACPI doesn't suck.

I've fixed the problem by writing a patch that effectively clamps the
'remaining capacity' to never exceed 'last full capacity'.  

This is definitely a problem with tseng's laptop, however, it is highly
visible and is a regression compared to the previous behaviour.  The
patch is also quite small.

The patch has been tested by myself (and causes no new ill effects) and
by the reporter of the bug who has confirmed that it solves the problem
that he reported.

Cheers.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]