Hi guys, I've implemented a fix for the zoom-to-fit crash. The problem was that I called gnome_canvas_get_scroll_offsets in the gantt_chart_reflow_idle function and that it did not always return up-to-date values. The old and large values caused an overflow and eventually a crash. The reason for calling get_scroll_offsets was to have the same scrolling behaviour when dragging the duration of a task while left of the project end as when right of the project end. The simple implementation (without get_scroll_offsets) would have the gantt scroll to the left in the latter case as soon as the cursor moves away from the right edge instead of staying stationary until the cursor reaches the left edge. This fix uses a dummy object on the gantt to prevent the scrollable area from shrinking as a task duration is decreased. The dummy object is only present while dragging. Like Kurt said it's probably easier to have changes in a public repo, so I put up my public planner repo at: http://www.kfk4ever.com/~griffon26/planner.git Or via gitweb: http://www.kfk4ever.com/gitweb.cgi?p=planner.git;a=summary You'll find the fix in there. I'll push this in a few days if nobody objects. Regards, Maurice. -- Maurice van der Pot Gentoo Linux Developer griffon26 gentoo org http://www.gentoo.org Gnome Planner Developer griffon26 kfk4ever com http://live.gnome.org/Planner
Attachment:
pgpZtveC8lnVt.pgp
Description: PGP signature