Re: Merging two functions in mrp-task-manager.c

[Kurt Maute <Kurt Maute us>]

On Sun, 2008-01-20 at 16:39 +0100, Maurice van der Pot wrote:
> While working on a fix for some bug I noticed that
> task_manager_calculate_task_finish and
> task_manager_calculate_start_from_finish are incredibly similar and that
> the duplication is causing some problems. Some bugs that are present in 
> both functions are being fixed in only one of them. Also features are 
> sometimes added to one and forgotten in the other.
> 
> See here for a diff (generated with kdiff3 using manual diff alignments):
> http://www.kfk4ever.com/~griffon26/shared/plannerdiff.pdf
> 
> My proposal is to merge these functions into one and adding a parameter
> to select the behaviour. This may result in some ifs, but I'd rather
> have that than the current code duplication.

sounds like a good idea to me