Re: [Planner Dev] Patch for undo adding/removing predecessors form task dialog

[Richard Hult <richard imendio com>]

On ons, 2004-06-09 at 22:27 +0000, Alvaro del Castillo wrote:
> Hi!
> 
> El mié, 09-06-2004 a las 08:08, Richard Hult escribió:
> > On ons, 2004-06-09 at 06:55 +0000, Alvaro del Castillo wrote:
> > > Hi!
> > > 
> > > El mar, 08-06-2004 a las 18:02, Richard Hult escribió:
> > > > On tis, 2004-06-08 at 07:02 +0000, Alvaro del Castillo wrote:
> > > > > Hi guys!
> > > > > 
> > > > > Here goes a new patch to undo adding/removing predecessors from the task
> > > > > dialog. The code is the same we use in planner-task-tree to do the same
> > > > > operation, so I have moved the code from planner-task-tree to
> > > > > planner-task-dialog and share between them.
> > > > 
> > > > That feels a bit backwards to me (since the commands isn't really what I
> > > > would put in the task dialog API). We could break them out in a separate
> > > > file perhaps. But let's not do that now, we can file a bug and take care
> > > > of it later.
> > > > 
> > > 
> > > Yes, I have the same feeling, and putting the command in a separate file
> > > called "planner-task-cmd-undo.[ch]". Maybe we can use the same idea to
> > > "planner-resource-cmd-undo.[ch]" and continue it. What do you think?
> > 
> > I'd prefer planner-{task,resource}-cmd.[ch] if so. But maybe we should
> > save that for later?
> > 
> 
> Yes, we can wait but it is so simple ... if we have
> planner-task-cmd.[ch] it will remember us that this is the way to
> follow. When I finish the predecessor dialog, I will contact you to take
> a final decission before commit.
> 
> Cheers
> 
> -- Alvaro
> 
> > /Richard
> _______________________________________________
> Planner-dev mailing list
> Planner-dev lists imendio com
> http://lists.imendio.com/mailman/listinfo/planner-dev