Re: [Planner Dev] Patch for undo adding/removing predecessors form task dialog

[Richard Hult <richard imendio com>]

On tis, 2004-06-08 at 07:02 +0000, Alvaro del Castillo wrote:
> Hi guys!
> 
> Here goes a new patch to undo adding/removing predecessors from the task
> dialog. The code is the same we use in planner-task-tree to do the same
> operation, so I have moved the code from planner-task-tree to
> planner-task-dialog and share between them.

That feels a bit backwards to me (since the commands isn't really what I
would put in the task dialog API). We could break them out in a separate
file perhaps. But let's not do that now, we can file a bug and take care
of it later.

Looks good otherwise.

> The problems with phantoms arrows in the gantt view appear so we will
> need debugging time and solve the open bug with a patch:
> 
> http://bugs.gnome.org/show_bug.cgi?id=141346
> 
> I feel they are related.
> 
> This bug isn't in 0.12 release bugs. I think we need to solve it before
> releasing 0.12 because strange things happens in the gantt chart using
> the undo/redo system so the user will stop to use it.

Agreed, I moved it to 0.12.

/Richard

-- 
Imendio HB, http://www.imendio.com/