Hi! El mar, 08-06-2004 a las 18:02, Richard Hult escribió: > On tis, 2004-06-08 at 07:02 +0000, Alvaro del Castillo wrote: > > Hi guys! > > > > Here goes a new patch to undo adding/removing predecessors from the task > > dialog. The code is the same we use in planner-task-tree to do the same > > operation, so I have moved the code from planner-task-tree to > > planner-task-dialog and share between them. > > That feels a bit backwards to me (since the commands isn't really what I > would put in the task dialog API). We could break them out in a separate > file perhaps. But let's not do that now, we can file a bug and take care > of it later. > Yes, I have the same feeling, and putting the command in a separate file called "planner-task-cmd-undo.[ch]". Maybe we can use the same idea to "planner-resource-cmd-undo.[ch]" and continue it. What do you think? > Looks good otherwise. > > > The problems with phantoms arrows in the gantt view appear so we will > > need debugging time and solve the open bug with a patch: > > > > http://bugs.gnome.org/show_bug.cgi?id=141346 > > > > I feel they are related. > > > > This bug isn't in 0.12 release bugs. I think we need to solve it before > > releasing 0.12 because strange things happens in the gantt chart using > > the undo/redo system so the user will stop to use it. > > Agreed, I moved it to 0.12. > Ok, I will continue working in the patch to complete the editing of a predecessor relation and I will commit maybe using a new file. Cheers -- Alvaro > /Richard
Attachment:
signature.asc
Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente