Re: [PATCH] lib/pull: allways include ostree-repo-pull-private.h



Hi Colin,

On Thu, Dec 21, 2017 at 04:34:56PM -0500, Colin Walters wrote:
Thanks for the patch!  Hmm...we have a "minimal" CI build that's supposed
to catch things like this but apparently we do build with other things disabled
(perhaps libarchive)?  I'm too lazy to experiment with combinatorics so for
now: thanks for the patch!

I have submitted libostree as a package to buildroot [1], and they build
with different configurations 24/7, so that's how I discovered this
issue.


Patches via mailing list are fine, but I've submitted it to
https://github.com/ostreedev/ostree/pull/1389
as we have a policy at the moment that commits to master are done
via the Homu merge bot and that only understands github.

Fine with me!
I appreciate that you can send patches to the mailing list, it is more
my type of workflow. However, I will consider github next time (at least
for bigger patchsets) to minimize the extra work it implies for you.

Thanks,
Marcus Folkesson


[1] https://buildroot.org/

Attachment: signature.asc
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]