Re: kernel cmdline - allow duplicate keys
- From: Dusty Mabe <dustymabe gmail com>
- To: ostree-list gnome org
- Subject: Re: kernel cmdline - allow duplicate keys
- Date: Tue, 5 Aug 2014 00:25:42 -0400
On Sun, Aug 03, 2014 at 02:36:49PM -0400, Colin Walters wrote:
On Sat, Aug 2, 2014, at 11:12 AM, Dusty Mabe wrote:
Yes. The attached patch does work nicely for the --karg-proc-cmdline case
so I think
in the very least you should commit it.
Done.
I think we still have some issues here to address though as the "merging"
code, (on a
subseqent deployment) will end up ripping out the duplicate keys.
Ahh, yes - this is a similar bug just a few lines down. I've attached a
patch. Note that AFAICS this bug *only* exists in the "deploy" command.
If you use "upgrade", we correctly preserve multiple kernel args, and
the test code I've added shows that.
Right?
Seems to work fine. If I find any problems with further testing I'll
be sure to let you know :)
Dusty
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]