On Sat, Aug 2, 2014, at 11:12 AM, Dusty Mabe wrote:
Yes. The attached patch does work nicely for the --karg-proc-cmdline case so I think in the very least you should commit it.
Done.
I think we still have some issues here to address though as the "merging" code, (on a subseqent deployment) will end up ripping out the duplicate keys.
Ahh, yes - this is a similar bug just a few lines down. I've attached a patch. Note that AFAICS this bug *only* exists in the "deploy" command. If you use "upgrade", we correctly preserve multiple kernel args, and the test code I've added shows that. Right?
Attachment:
0001-deploy-Also-honor-multiply-specified-kernel-args-wit.patch
Description: Text Data