Re: [orca-list] regression in the menus with check box under qt (teamtalk)

[Joanmarie Diggs <jdiggs igalia com>]

+ Chrys who has done some work around Qt accessibility

Looking at the change you cited, my guess is that my fix in Orca 
uncovered a bug in Qt: Things which can be checked should have the 
"checkable" state. Mind you, Orca assumes certain things are checkable 
even when apps/toolkits fail to expose that state. For instance, Orca 
assumes that check boxes and check menu items are always checkable.

The "checkable" state comes in especially handy for things which may or 
may not be checkable and the role is insufficient to know for sure.

A normal menu item which lacks the checkable state is presumed to not be 
checkable. My fix in Orca causes Orca to correctly say "not checked" for 
menu items which are checkable but not checked, letting the user know 
that there is the possibility to toggle the state of that item.

If this is indeed what's going on, I could potentially add a just-for-Qt 
workaround. But then Orca would have the bug of failing to say "not 
checked" for Qt menuitems which are checkable. Therefore I think one of 
the following is the correct thing to do:

1. Checkable menu items should use ROLE_CHECK_MENU_ITEM; not 
ROLE_MENU_ITEM and/or
2. Checkable menu items which cannot have ROLE_CHECK_MENU_ITEM as 
expected should have STATE_CHECKABLE in their state set.

Chrys, if you have some spare cycles, could you please look into this? 
Bonus points for causing a fix to land in Qt. :)

Thanks in advance!
--joanie

On 4/27/20 10:19, Joanmarie Diggs wrote:
> Hi Jerem.
>
> Thanks for the report. Do you have steps for me to reproduce the problem 
> using a particular app?
>
> --joanie
>
> On 4/26/20 15:43, Jérémy Prego via orca-list wrote:
> > hello,
> >
> > I had noticed in the past few weeks this bug, but I thought it was just
> > an update of qt which had broken up the accessibility. but infact not,
> > this bug comes from orca from the 3.36.1...
> >
> > to better describe the bug, since the commit
> > 4c8504ef79f06444ecd49d66c48ea089fb17b1c2 (    Treat checkable items with
> > role menu item the same as checkable list items), orca does not say when
> > the menu item is checked.
> >
> > debug ok (orca < 3.36.1):
> > https://hastebin.milkywan.fr/odezequkuz.coffeescript
> > debug KO: (orca master):
> > https://hastebin.milkywan.fr/pokuzihede.coffeescript
> >
> > thank in advance for the fix !
> >
> > Jerem
> > _______________________________________________
> > orca-list mailing list
> > orca-list gnome org
> > https://mail.gnome.org/mailman/listinfo/orca-list
> > Orca wiki: https://wiki.gnome.org/Projects/Orca
> > Orca documentation: https://help.gnome.org/users/orca/stable/
> > GNOME Universal Access guide: 
> > https://help.gnome.org/users/gnome-help/stable/a11y.html
>
> _______________________________________________
> orca-list mailing list
> orca-list gnome org
> https://mail.gnome.org/mailman/listinfo/orca-list
> Orca wiki: https://wiki.gnome.org/Projects/Orca
> Orca documentation: https://help.gnome.org/users/orca/stable/
> GNOME Universal Access guide: 
> https://help.gnome.org/users/gnome-help/stable/a11y.html