Re: [orca-list] AtkText interfaces

[Alejandro Piñeiro <apinheiro igalia com>]

On 20/10/17 14:29, Eric Williams wrote:
> Hello,
>
> On 10/20/2017 07:37 AM, Joanmarie Diggs wrote:
> > I would have to check, but I thought that AT-SPI2 was mapping the new
> > ATK API to the existing/old API. Is that not the case?
>
>
> I am not sure what you mean by this, could you please clarify?

When we added the new API, we didn't want to break the applications
using the old API. So the idea was Orca using the new method, and
at-spi2 checking if the new API was implemented or not. If it was not
the case, then it would fallback/wrap to the old API. The idea (2) was
this to be a temporal solution, but as you pointed, GTK3 still doesn't
implement he new API. WebKitGTK already did the move though (more below).

But as Mike said on a email I have just set, at-spi2-atk only wraps the
new API over the old API, but not the opposite.
> > On 10/20/2017 11:22 AM, Eric Williams wrote:
> > > Hello,
> > >
> > > I am implementing AtkText interfaces for the GTK3 implementation of
> > > Eclipse SWT.
> > >
> > > Currently we use atk_text_get_text_[before/at/after]_offset(), which
> > > are
> > > deprecated. However when I replace these interfaces with
> > > atk_text_get_string_at_offset(), Orca fails to read text where it
> > > previously did. In fact, Orca doesn't call/query
> > > atk_text_get_string_at_offset() at all.

Yes, the idea was that Orca would migrate to the new API. Probably it
was a miscommunication during that GUADEC hackfest, as we finished the
new ATK API on a GUADEC. The WebKitGTK implementation was added some
time after that. Toolkits that migrated, like the mentioned WebKitGTK
still works, because as far as I see, when they implemented the new API,
they didn't remove the old one:

https://bugs.webkit.org/show_bug.cgi?id=120638
https://trac.webkit.org/changeset/157165/webkit

So, summarizing. If Orca moves to the new API, that should work on
toolkits implementing the old API, thanks to the at-spi2 plumbing. Not
sure if Orca has plans to do that move soon though.

> > > As a side note: I've noticed that the native GTK3 accessibility
> > > implementation still uses the deprecated
> > > atk_text_get_text_[before/at/after]_offset() interfaces.

Yes, they still didn't move to the new API.

> > > Is this a bug or am I missing some detail?
> > >
> > > Thanks,
> _______________________________________________
> orca-list mailing list
> orca-list gnome org
> https://mail.gnome.org/mailman/listinfo/orca-list
> Orca wiki: https://wiki.gnome.org/Projects/Orca
> Orca documentation: https://help.gnome.org/users/orca/stable/
> GNOME Universal Access guide:
> https://help.gnome.org/users/gnome-help/stable/a11y.html
> Log bugs and feature requests at http://bugzilla.gnome.org