Re: [orca-list] Orca does not read selected text in Evince

[Joanmarie Diggs <jdiggs igalia com>]

Sorry for the back-to-back messages. If I disable caret navigation in
Evince, I can reproduce the problem. Caret navigation being enabled in
Evince is expected in order to read the document with Orca. That said,
I'll see what I can do. Thanks for the report!

--joanie

On 01/30/2017 10:35 AM, Joanmarie Diggs wrote:
> Hi Juliano.
>
> I just tried selecting text with the mouse using Orca master and Evince
> 3.22.1. The selected text was correctly spoken for me. Does this problem
> happen for you with all documents or just some? Does it happen under all
> conditions or just some?
>
> Thanks!
> --joanie
>
> On 01/29/2017 07:12 PM, Juliano Cardoso Vacaro wrote:
> > Hi Everyone, 
> >
> > I believe I found a small bug in Orca when using evince, and would like
> > your feedback to confirm. 
> >
> > steps to reproduce:
> > 1) open a pdf in evince 
> > 2) select a given text with the mouse 
> > 3) ask Orca to read it 
> >
> > Actual result:
> > Text is not read. The message "no selected text" is announced by Orca
> > instead.
> >
> > Expected result:
> > Orca should read the selected text. 
> >
> > Environment:
> > Orca from master 
> > updated Debian sid/unstable 
> > GNOME-shell 3.22.2
> > Evince 3.22.1
> >
> > Investigation:
> > In the method selectedText from orca/script_utilities.py, I noticed that
> > the locusOfFocus object refers to the Evince Document, not to the Evince
> > Page. Since Evince Page is the one which implements the ATK text
> > interface, the method does not work correctly. 
> >
> > Looking at the method onCaretMoved from
> > orca/src/orca/scripts/apps/evince/script.py, I noticed the following
> > statement:
> >
> >         if obj.getState().contains(pyatspi.STATE_FOCUSED):
> >             orca.setLocusOfFocus(event, event.source, False)
> >             
> > Then, I just added the same logic to the onTextSelectionChanged method
> > in the same script. Now things are much better. 
> >
> > Do you think that this fix is the correct approach, or we should change
> > Evince so that Orca should correctly update the locusOfFocus object?
> >
> > Patch:
> > https://github.com/jcvacaro/orca/tree/ev-seltext
> >
> > Thanks a lot, 
> > Juliano 
> >
> >
> >
> > _______________________________________________
> > orca-list mailing list
> > orca-list gnome org
> > https://mail.gnome.org/mailman/listinfo/orca-list
> > Orca wiki: https://wiki.gnome.org/Projects/Orca
> > Orca documentation: https://help.gnome.org/users/orca/stable/
> > GNOME Universal Access guide: https://help.gnome.org/users/gnome-help/stable/a11y.html
> > Log bugs and feature requests at http://bugzilla.gnome.org
>
> _______________________________________________
> orca-list mailing list
> orca-list gnome org
> https://mail.gnome.org/mailman/listinfo/orca-list
> Orca wiki: https://wiki.gnome.org/Projects/Orca
> Orca documentation: https://help.gnome.org/users/orca/stable/
> GNOME Universal Access guide: https://help.gnome.org/users/gnome-help/stable/a11y.html
> Log bugs and feature requests at http://bugzilla.gnome.org