Re: [orca-list] Initial clickable support added to master

[Peter Vágner <pvdeejay gmail com>]

Hello,
Onclick support is great however unfortunatelly I have found an edge 
case where onclick event is not taken into account.
When the whole row or whole table is clickable orca is not reporting to 
that fact.
I am afraid this is kind of bad practice anyway but still quite frequent 
on the web when container objects are clickable.
Attached is a test case. That's a simple table with header columns at 
the top, one clickable and one non clickable colum in the following row 
and the last row which is whole clickable. The fact last row is 
clickable is not reported by orca.
Is this worth looking into? I am afraid it might add whole layer of 
complexity however I am also afraid there are more significant scenarios 
on the web which might not be covered with the current implementation.

Greetings

Peter


On 15.08.2014 at 00:59 kendell clark wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> yay!
> Testing now. I'll report back with any bugs, but I doubt I'll find
> many, if any.
> Thanks
> Kendell clark
>
>
> On 08/14/2014 05:52 PM, Joanmarie Diggs wrote:
> > Hey all.
> >
> > Here's the deal: * Clickables are announced as you do caret
> > navigation * A and Shift+A move you amongst clickables * Alt +
> > Shift + A gives you a list of clickables * If you move to a
> > clickable using any of the above methods, you can then click on the
> > clickable via KeyPad / in desktop layout; Orca + 7 in laptop
> > layout * As with the links lists dialogs, you can activate/click
> > on on clickables without having to synthesize the click; just press
> > the Activate button (mnemonic in English, Alt+A) * Clickables are
> > underlined in braille and clickable from the braille display
> >
> > Note that at the moment, navigating amongst clickables is not quite
> > as performant as I'd like. This is due to the following AT-SPI2
> > bug(s): https://bugzilla.gnome.org/show_bug.cgi?id=734805
> >
> > Once that bug is fixed, then I will enable proper collections
> > support. In the meantime, this works well enough and gets the
> > feature and strings into master prior to the relevant GNOME
> > freezes. I can still fix bugs after those freezes.
> >
> > Lastly, I'm sure someone will say, "Enter and Space should
> > activate clickables." As I have already stated, the problem with
> > that is that it would mean that each and every time you pressed
> > Enter or Space, Orca would need to:
> >
> > 1. Figure out if you are in document content, if so: 2. Figure out
> > what mode you were in 3. Figure out if you were on anything
> > focusable or a clickable 4. Determine what action to perform based
> > on what type of object you are on and whether or not you pressed
> > Enter or Space. This heuristic would undoubtedly be buggy and need
> > more checks and special casing added to try to get it right.
> >
> > And you press Enter and Space a lot I bet. So that's adding
> > non-performant and likely buggy code that will get called alot. And
> > the reason it would do this is because there are some
> > non-focusable clickables out there. Orca already has a "click"
> > command that works well and now Orca announces their presence and
> > gives you a means to quickly move to them and click on them.
> >
> > BTW, just in case you are wondering, what Orca normally does when
> > you press Enter or Space is:
> >
> > 1. Note that you pressed that key 2. There is no 2. It just notes
> > the input event down This is performant and non-buggy.
> >
> > Having said all that, please test and let me know what you think.
> > Thanks!
> >
> > --joanie _______________________________________________ orca-list
> > mailing list orca-list gnome org
> > https://mail.gnome.org/mailman/listinfo/orca-list Visit
> > http://live.gnome.org/Orca for more information on Orca. The manual
> > is at
> > http://library.gnome.org/users/gnome-access-guide/nightly/ats-2.html
> The FAQ is at http://live.gnome.org/Orca/FrequentlyAskedQuestions
> > Log bugs and feature requests at http://bugzilla.gnome.org Find out
> > how to help at http://live.gnome.org/Orca/HowCanIHelp
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCgAGBQJT7T9FAAoJEGYgJ5/kqBTdW5wQAKdaerLKxunf1XgUv3rWuPqB
> KxojNVPOTkA+mCl3Q417w1chL2lg2fnoG4mkzlFyP+MBo5c8lB2J2o2Ehx7KxMqy
> SqCD86jBqAgL2cuqs22q9RjZGCkAB3RctZAHJYbmdVRF5zSVXGMQbxF9gsYXcO9T
> GT1d9whu9tTVO+2LXFstYPUv6BG3dN5BMiiDNcJqP+qNyd2GU4UVRhyu9VQcVEj3
> C7K1kY8Z1luk3Ez24IVoGRVGLBwxfuiiRddpzVDGXdlpDJhsq40oY/5B4//8YhRv
> 794BbY4CMkysHDYkM0lDQWbJwEvzF9lpUP3sKzE2zd71QfU6gLyGOI74JavPw0f1
> egpbZ2nDF5XGSJlezJ9LNfxEUsRKTlf3ewVqE5GDQhnCXi2jaUzeKDBQnvqBBo8k
> hTIianoWv6zq+Vu+sCp3NUvIP6qwFUlW7eT/G9pK7iAM2u5E/T1mhb8UgFkAbLo1
> XAfhNLnN7mX54DE+YbflHr/B0P80OE84dr/kvt5j0G9aPGXxamfEYeim6cLgcF0A
> 3JkQMmVDx7DvcRUZg+ApG4PvBsHQ7wR49z1Hcc27XwcWe/IJzJSfa9A/CGY0e7EI
> XiVynXoqqUz+ZNNxivDfUytPTSwFM3KZChuPWnNQtM/x/gNJ0PqmY+2JvzjXDYuH
> qz9nyMpOhqzssA+KgBYD
> =px8M
> -----END PGP SIGNATURE-----
> _______________________________________________
> orca-list mailing list
> orca-list gnome org
> https://mail.gnome.org/mailman/listinfo/orca-list
> Visit http://live.gnome.org/Orca for more information on Orca.
> The manual is at http://library.gnome.org/users/gnome-access-guide/nightly/ats-2.html
> The FAQ is at http://live.gnome.org/Orca/FrequentlyAskedQuestions
> Log bugs and feature requests at http://bugzilla.gnome.org
> Find out how to help at http://live.gnome.org/Orca/HowCanIHelp

Title: Onclick test case

header1	header2
Click me	Do not click me
Click me	Click me