Orca Speaking blank lines



Looks like I finally have a working Ubuntu/Orca install. Now I'm trying to make it into a usable development/recording environment for some projects I'm undertaking.

But, anyway, I experienced a minor annoyance for which I have a patch, but before submitting it to bugzilla I want to make sure a) there isn't some other way/good reason for things being done this way, and b) that I've in fact made the change in the best place for it. :) When editing documents, I was annoyed by Orca not speaking blank lines, because when I press a key and don't receive any feedback I generally assume that nothing happens--I've reached the top/bottom of the list/whatever and focus doesn't wrap, there is no valid use for that key, etc.

I went to default.py, and noticed that the sayLine() method is specifically written to ignore blank lines. So I initialized the default voice outside of the "if len(line):" clause, added an "else" and spoke the phrase "blank". Now I've got semi-functional speaking of blank lines (though there's weirdness in OpenOffice where "blank" is sometimes spoken twice, or in addition to the new line.)

Have I implemented this change in the correct place, or is there a better way to implement speaking of blank lines when they're arrowed through in text areas? It's a feature of all other screen-readers I'm aware of, so that the docstring specifically mentions that blank lines are ignored has me thinking that perhaps I've implemented this in the wrong place. :)

Thanks.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]