evil bug in orbit-small.c's fixedness-checking code



this was just plain evil. can I check it in?

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/ORBit2/ChangeLog,v
retrieving revision 1.357
diff -u -u -r1.357 ChangeLog
--- ChangeLog   10 Apr 2002 17:22:57 -0000      1.357
+++ ChangeLog   12 Apr 2002 23:11:40 -0000
@@ -1,3 +1,9 @@
+2002-04-13  ERDI Gergo  <cactus@cactus.rulez.org>
+
+       * src/orb/orb-core/orbit-small.c (ORBit_small_invoke_adaptor):
+       Check for FIXED flag on the argument type and not the method (as
+       that would be silly:)
+
 2002-04-10  Michael Meeks  <michael@ximian.com>
 
        * configure.in: remove poll & basename checks,
Index: src/orb/orb-core/orbit-small.c
===================================================================
RCS file: /cvs/gnome/ORBit2/src/orb/orb-core/orbit-small.c,v
retrieving revision 1.61
diff -u -u -r1.61 orbit-small.c
--- src/orb/orb-core/orbit-small.c      6 Feb 2002 18:08:02 -0000
1.61
+++ src/orb/orb-core/orbit-small.c      12 Apr 2002 23:11:41 -0000
@@ -746,7 +746,7 @@
                                break;
                        case STRUCT_UNION_TYPES:
                        case CORBA_tk_array:
-                               if (m_data->flags &
ORBit_I_COMMON_FIXED_SIZE) {+                               if (a->flags &
ORBit_I_COMMON_FIXED_SIZE) {
                                        scratch [i] = ORBit_alloc_by_tc
(tc);
                                        break;
                                } /* drop through */


-- 
   .--= ULLA! =---------------------.   `We are not here to give users what
   \     http://cactus.rulez.org     \   they want'  -- RMS, at GUADEC 2001
    `---= cactus@cactus.rulez.org =---'
Give a man a match and he'll be warm for an hour; light him on fire and he'll be warm for the rest of his life.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]