Re: [PATCH] Fix background_color in hippo css



On Wed, 2008-04-09 at 18:09 +0200, Marco Pesenti Gritti wrote:
> With this fix we have back prelighting and visual selection in the
> browsers (which was on Owen list).
> 
> It was working for the canvas element only because it's going through
> a different code path there.

Thanks for tracking this down! Patch looks fine to me (I'd have
just put the property_name += 10 after the continue but a trivial
difference...)

- Owen

> Index: common/hippo/hippo-canvas-style.c
> ===================================================================
> --- common/hippo/hippo-canvas-style.c   (revision 7250)
> +++ common/hippo/hippo-canvas-style.c   (working copy)
> @@ -728,7 +728,9 @@
>              CRDeclaration *decl = style->properties[i];
>              const char *property_name = decl->property->stryng->str;
> 
> -            if (!g_str_has_prefix(property_name, "background"))
> +            if (g_str_has_prefix(property_name, "background"))
> +                property_name += 10;
> +            else
>                  continue;
> 
>              if (strcmp(property_name, "") == 0) {

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]