Re: r6936 - in dumbhippo/trunk: . server/src/com/dumbhippo/persistence server/src/com/dumbhippo/server server/src/com/dumbhippo/server/impl



On Tue, 2007-11-20 at 18:32 -0600, commits mugshot org wrote:

> Modified: dumbhippo/trunk/.classpath
> ===================================================================
> --- dumbhippo/trunk/.classpath	2007-11-20 23:05:42 UTC (rev 6935)
> +++ dumbhippo/trunk/.classpath	2007-11-21 00:32:51 UTC (rev 6936)
> @@ -112,6 +112,6 @@
>  	<classpathentry kind="lib" path="openfire/src/plugins/userImportExport/lib/msv.jar"/>
>  	<classpathentry kind="lib" path="openfire/src/plugins/userImportExport/lib/isorelax.jar"/>
>  	<classpathentry kind="var" path="HIPPO_TRUNK_LIB/server/dom4j-1.6.1.jar"/>
> -	<classpathentry kind="lib" path="lib/server/facebook.jar"/>
> +	<classpathentry kind="lib" path="HIPPO_TRUNK_LIB/server/facebook.jar"/>
                                ^^^

This looks wrong to me, though it does seem to work, somehow.

> Modified: dumbhippo/trunk/server/src/com/dumbhippo/server/impl/IdentitySpiderBean.java
> ===================================================================
> --- dumbhippo/trunk/server/src/com/dumbhippo/server/impl/IdentitySpiderBean.java	2007-11-20 23:05:42 UTC (rev 6935)
> +++ dumbhippo/trunk/server/src/com/dumbhippo/server/impl/IdentitySpiderBean.java	2007-11-21 00:32:51 UTC (rev 6936)
> @@ -39,6 +39,7 @@
>  import com.dumbhippo.persistence.EmailResource;
>  import com.dumbhippo.persistence.ExternalAccount;
>  import com.dumbhippo.persistence.ExternalAccountType;
> +import com.dumbhippo.persistence.FacebookResource;
>  import com.dumbhippo.persistence.Group;
>  import com.dumbhippo.persistence.GuidPersistable;
>  import com.dumbhippo.persistence.LinkResource;
> @@ -407,6 +408,9 @@
>  			DataService.currentSessionRW().changed(UserDMO.class, claimedOwner.getGuid(), "aim");
>  		else if (res instanceof XmppResource)
>  			DataService.currentSessionRW().changed(UserDMO.class, claimedOwner.getGuid(), "xmpp");
> +		// TODO: is there a list of property names anywhere that needs to be updated?
> +		else if (res instanceof FacebookResource)
> +			DataService.currentSessionRW().changed(UserDMO.class, claimedOwner.getGuid(), "facebook");

The names here are names of properties on UserDMO. Since you didn't add
a property on UserDMO, there should be no call to changed() for that
property.

- Owen

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]