Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote:
From: Tomáš Čech <sleep_walker gnu org>


This was not done intentionally (so far).

Clients (nm-applet, nmcli) may load the client parts of the VPN plugins
(the libnm.plugin setting from the .name file).
That's useful to show the GTK configuration dialog or implement `nmcli
connection import`.
These applications run in the user's context, and it makes sense that a
user compiles a VPN plugin that he/she installs in a private patch
(setting NM_VPN_PLUGIN_DIR). It's their choice.

But the daemon runs as root, so setting NM_VPN_PLUGIN_DIR requires you
to become root, to restart the daemon, and to set the environment
variable (in the systemd service file). At that point, you could just
as well copy the .name file to /usr/lib/NetworkManager/VPN. Why is that
not sufficient?

+     file = g_file_new_for_path (conf_dir_user);
+     priv->monitor_etc = g_file_monitor_directory (file,
+     g_object_unref (file);
+     if (priv->monitor_etc) {

btw, you cannot overwrite the existing monitor_etc and monitor_id_etc
fields. It would require new ones...


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]