Re: No new PIN request to the user if PIN stored in settings is wrong

[Dan Williams <dcbw redhat com>]

On Thu, 2018-09-27 at 12:22 +0200, Thomas Haller via networkmanager-
list wrote:
> On Thu, 2018-09-27 at 11:51 +0200, Aleksander Morgado wrote:
> > Hey,
> >
> > I'm trying to understand whether this behavior is on purpose or
> > not.
> >
> > I have some "gsm" settings for a broadband connection, and the
> > settings have a PIN stored. I then try to use those settings on a
> > modem device but the expected PIN in the modem is a different one,
> > so
> > the connection attempt fails with a "sim-pin-incorrect" reason. At
> > this point NetworkManager doesn't request the user new secrets for
> > this connection after finding that the stored ones are wrong; i.e.
> > i
> > don't see any popup window in the shell asking to enter PIN. The
> > connection attempt just fails and we do get reported in the UI
> > about
> > the failed attempt.
> >
> > Is this behavior (asking the user for PIN after a "sim-pin-
> > incorrect"
> > failure) not implemented or am I missing some reason that would
> > prevent doing that? The behavior is different e.g. with WiFi; if I
> > change the key in my router and I request NM to connect to the WiFi
> > network, the authentication failure triggers a new request for
> > secrets
> > to the user.
> >
> > Cheers!
>
>
> Hi,
>
>
> sounds like a bug. If a secret/pin is wrong, NM should re-ask for it.

We do have to be careful here, because by the time NM asks for the PIN,
we've already tried the stored PIN once, and if the user enters the
wrong pin in the dialog you have one try left before the PIN is
blocked.  And then you have to find your PUK which often isn't right
next to you.

Dan