Re: [PATCH] connectivity: allow 204 (no content) as connectivity test

On Thu, 2018-02-08 at 21:28 +0100, Aleksander Morgado wrote:
If the user is requesting an empty response ("") as expected string,
let the connectivity check succeed if we actually get a 204 HTTP
response code (reporting a successful request but without content).

This allows using e.g. Android's default URLs for the connectivity
check purpose:


Hey hey,

What do you think of this patch? This should work for all cases,
including when trying to detect a captive portal (as the portal
shouldn't return a 204 in any case).

Hi Aleksander,

I think this makes sense.

Merged to master:

and a minor follow up:


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]