Re: [PATCH v3] examples: linker requires that library dependencies follow use

From: Thomas Haller <thaller redhat com>
To: Lucas Rangit Magasweran <lucas magasweran ieee org>
Cc: networkmanager-list gnome org
Subject: Re: [PATCH v3] examples: linker requires that library dependencies follow use
Date: Thu, 21 Sep 2017 13:24:33 +0200

On Wed, 2017-09-20 at 14:13 -0700, Lucas Rangit Magasweran wrote:

On modern distributions, ld runs with the '--as-needed' option
enabled by default, meaning library dependencies must come after
files that require them. Also, this allows indirect linking so the
build commands can be simplified.

The alternative is to add the '-Wl,--no-as-needed' gcc option or use
the top-level Makefile.

Tested on:
 * Ubuntu 16.04.3 with gcc Ubuntu 5.4.1-8ubuntu1
 * Fedora 24 with gcc Red Hat 6.1.1-3

Signed-off-by: Lucas Magasweran <lucas magasweran ieee org>
---
Changes in v3:
  - Fixed line wrapping. Sorry about that.


Hi Lucas,

merged as 
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=843ea77e93af230ba113adae2ed92fe80db83717

Thanks!
Thomas

Attachment: signature.asc
Description: This is a digitally signed message part

References:
- [PATCH v2] examples: gcc linker requires library depencencies come after they are needed
  - From: Lucas Rangit Magasweran
- Re: [PATCH v2] examples: gcc linker requires library depencencies come after they are needed
  - From: Thomas Haller
- [PATCH v3] examples: linker requires that library dependencies follow use
  - From: Lucas Rangit Magasweran

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]