Am 02.10.2017 um 08:58 schrieb Olaf Hering:
On Sun, Oct 1, Oliver Freyermuth <o freyermuth googlemail com> wrote:Is this a bug, or a feature?This is a bug. I'm sure no standard requires the DHCP server to come back within 3 minutes. NetworkManager must keep retrying, forever.
Thanks for confirming! That's exactly what I thought should be the case.
Reported here: http://bugzilla.suse.com/show_bug.cgi?id=584544 Workaround here: https://build.opensuse.org/request/show/519609
Both these (downstream) reports seem to be closed as WONTFIX. Is this also tracked upstream somewhere? Is specifying autoconnect-retries-default=0 in the [main] section of NetworkManager.conf a working workaround until this fundamental issue is resolved (which would work without recompiling)?
--- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -79,7 +79,7 @@ _LOG_DECLARE_SELF (NMDevice); /*****************************************************************************/ #define DHCP_RESTART_TIMEOUT 120 -#define DHCP_NUM_TRIES_MAX 3 +#define DHCP_NUM_TRIES_MAX -1UL #define DEFAULT_AUTOCONNECT TRUE /*****************************************************************************/ Complete fix is to wipe all usage of DHCP_NUM_TRIES_MAX.
I agree. Thanks for the workaround, but to get things going into all downstream distributions, a fix accepted
upstream would be good.
Cheers and thanks,
Oliver
Attachment:
signature.asc
Description: OpenPGP digital signature