Re: [PATCH] Use default active interface, even if it is of unsupported class



On Mon, May 22, 2017 at 10:48:58PM -0400, Nikolay Martynov wrote:
Hi.

Just a kind ping. This patch was sent at the same time as one other
patch - which got merged quite some time ago. Just wanted to make sure
this one doesn't fall through the cracks.
Thanks!

2017-05-16 23:15 GMT-04:00 Nikolay Martynov <mar kolya gmail com>:
Currently if I have bond interface running as my default interface and
I try to establish VPN connection I get route to VPN server added to
physical ethernet interface - one of bond slaves. This makes no sense
- that slave doesn't even have IP address, and obviously such VPN
connection fails to work.

The problem happanes because we try to determine what interface has
default route and we skip all interfaces that we do not know
about (i.e. anything that is not ethernet, wifi, wwan, modem and
BT). Since bond is not on the list code skips it.

It looks like code doesn't really care what type the 'default'
interface is - so that check is really not nessesary. Removing that
check fixes 'VPN with default route via bond' problem.

Patch LGTM.

Beniamino

Attachment: signature.asc
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]